01-projects/printables-product/reviews

Review-and-plan: lifecycle email/SMS (2026-10-20)

2026-10-20·review·status: gated-pass·by sw-critic review slot
printablesscribble-workslifecycleemailsms

Lifecycle email and text-message review, 2026-10-20

What was reviewed

origin/main @ 46ed046 (unchanged since 10-11): scripts/deploy/daily.mjs:15-51, :137-149, workers/daily-playset/wrangler-production.toml:13-18, deliver.js:239-272. #413 Phases 3-5; gh lists; deploy-daily run 38140447216 (10-11, latest). curl 05:12 ET: letter-sound-hunt, caceria-de-sonidos, ten-frame-race 404. queue.md, escalations.md, [[2026-08-31-studio-charter|charter]] lines as cited.

Since 10-13

Landed: R51 slot (queue.md:39), R39 path (:118), R50 widening (:133; #435 open). Open: D1 token (escalations.md:591, day 9); R39-R41 have no PR or issue (ranks 9, 10, none; :51-52).

Findings

  1. R51 cannot ship as written; queue.md:793 already says why. R51 (:146): set CATALOG_SOURCE="d1", "Test: configs match." The daily release pins production variables exactly (daily.mjs:26, "Production delivery variables changed") and halts on any live Worker drift from it (:51, via snapshot() :146). :793 (10-08) records this and asks for a plan-first GitHub issue; none exists. :39 parks R51 on the token; the design work is not token-gated.
  2. #413 phase 4 would freeze the paid email's game list. #422 switched only the website to D1. Phase 4 publishes by D1 flip plus a no-PR rebuild (founder ruling, #413 10-08), so the commit that redeploys the daily Worker today (affectsDaily, daily.mjs:15) stops happening. Without R51 first, new games never reach the email; phase 5's done-when ("in the next daily playset, with no commit") fails. #413 parks the daily Worker as a "separate follow-up" but never gates phases 4-5 on it; comment it there (engineering).

3-5 creation quality (charter:483): untouched.

Proposed queue.md changes

Engineering (charter:50); the :39 edit is product (:48).

@@ -39 +39 @@
-- R51: parked until escalations.md:591 lands, then first.
+- R51: plan-first GH issue now; the flip waits on escalations.md:591, then first.
@@ -146 +146 @@
-R51. [engineering, S] Daily Worker reads the site's catalog: CATALOG_SOURCE="d1" in workers/daily-playset/wrangler-production.toml, after the production D1 sync (escalations.md:591). Test: configs match. Bear: a D1 read failure skips the whole tick (deliver.js:272). Paid daily email currently can link to /game/ pages that 404 (letter-sound-hunt, ten-frame-race + ES twins).
+R51. [engineering, M, plan-first GH issue; absorbs :793] Daily Worker on the D1 catalog: a reviewed one-time variable transition through daily.mjs:26/:51, then CATALOG_SOURCE="d1". Test: release accepts only that transition. Bear: a D1 read failure skips the whole tick (deliver.js:272). Gates #413 phase 4.
@@ -793,0 +794 @@
+  - FOLDED into R51 (:146), 2026-10-20 lifecycle review.

Decisions needed

None new. Cited, not re-asked: D1 token (escalations.md:591); status-only token for /status (:526).