01-projects/printables-product/reviews

Review-and-plan: lifecycle email/SMS (2026-10-13)

2026-10-13·review·status: gated-pass·by sw-critic review slot
printablesscribble-workslifecycleemailsms

Lifecycle email and text-message review, 2026-10-13

What was reviewed

origin/main @ 46ed046 (10-11); read-only gh lists; public curl of five /game/ pages, three previews (05:1x ET); queue.md:35-44, :106-109, :122; escalations.md:526-527, :591; [[2026-10-06-lifecycle-email-sms]]; [[2026-08-31-studio-charter|charter]] §2 (:46-51). No user-data tables read.

Findings

  1. The paid daily email can link to pages that 404. The site reads its catalog from D1 (wrangler.toml:149). The daily Worker sets no CATALOG_SOURCE (workers/daily-playset/wrangler-production.toml:13-18), so liveGamesFor curates from the bundled catalog (deliver.js:240-244, #417). deploy-daily run 38140447216 (10-11 12:44Z, 46ed046) shipped letter-sound-hunt and ten-frame-race (shopper-catalog.json:1540, :2500). Their /game/ pages and both Spanish twins return 404; build-a-rocket returns 200. Each game URL prints in the text part (email.js:117); the HTML part shows only the preview (200). No sent email was checked. Cause: the D1-token blocker (escalations.md:591). The split outlives it: a D1 retire reaches the Worker only on release.
  2. R39, R40, R41 did not move. No PR or issue. Anchors unchanged: request.js:132 and invite.js:39 discard send results; README.md:15 still says "Verified 2026-09-10"; send.js:13-14 sets no List-Unsubscribe. Proposed as slots 6-7 ([[2026-10-06-lifecycle-email-sms]]), re-ranked 8-9 on 10-07 (queue.md:43-44); R41 has no slot.
  3. R39's invite path is ambiguous. Bare invite.js:39 (queue.md:107) reads as functions/api/auth/invite.js (absent); the send is functions/api/account/adults/invite.js:39.
  4. No planned check sees finding 1. R50 smokes /browse/ cards only (queue.md:122); the /status check counts delivery outcomes, not links (escalations.md:526).

Proposed queue.md changes

Engineering (charter:50); reorder is product (:48).

@@ -35,0 +36 @@ (items below renumber +1)
+1. R51 (paid email; once escalations.md:591 lands)
@@ -107 +107 @@
-R39. [engineering, S] ... invite.js:39).
+R39. [engineering, S] ... functions/api/account/adults/invite.js:39).
@@ -122 +122 @@
-R50. [engineering, XS] Post-deploy smoke: GET /game/<slug>/ for every /browse/ card; fail on any 404.
+R50. [engineering, XS] Post-deploy smoke: GET /game/<slug>/ for every /browse/ card and every slug in the daily Worker's bundled catalog; fail on any 404.
@@ after :123 (keeps the #429 design item in the 10-12 section) @@
+## 2026-10-13 review (reviews/2026-10-13-lifecycle-email-sms.md)
+R51. [engineering, S] Daily Worker reads the site's catalog: CATALOG_SOURCE="d1" in wrangler-production.toml, after the production D1 sync. Test: configs match. Bear: a D1 read failure skips the whole tick (deliver.js:272).

Decisions needed

None new. Cited, not re-asked:

  1. D1 catalog token (escalations.md:591). It now also fixes finding 1. Default: wait for his token.
  2. Status-only token for a daily /status check (escalations.md:526), still open. Default: lean yes; misses finding 1.
  3. escalations.md:465-467 (carried in :527).