01-projects/printables-product/reviews

Review-and-plan: lifecycle email/SMS (2026-10-06)

2026-10-06·review·status: gated-iterate-fixes-applied-not-regated·by sw-critic review slot
printablesscribble-workslifecycleemailsms

Lifecycle email and text-message review, 2026-10-06

What was reviewed

origin/main @ 3102087; read-only gh runs; dig; queue, escalations, rounds; [[2026-08-31-studio-charter|charter]] §2; [[2026-08-31-product-model-rulings|rulings]]; [[2026-09-29-lifecycle-email-sms]]. Since 09-29 only #402's curator changed lifecycle code by hand.

Findings

  1. 09-29's three queue edits landed; neither build started. The 10-04 check answered queue.md:337 (escalations.md:506); workers/daily-playset/README.md:15 still says "Verified 2026-09-10". :280-281 and :338 (unblocked, :506) sit untouched: functions/api/auth/request.js:132, invite.js:39 discard send results; guides-broadcast.mjs:138-139 takes any sender. Possible cause: no ranked slot (queue.md:35-40); a number alone has not moved R24, R25 or R29 (:69-70, :74).

  2. The daily email (paid product, rulings :137) changes with nearly every merge (daily.mjs:15); no check reads send outcomes. 14 green deploy-daily runs (10-04 11:43Z to 10-05 12:59Z) activated 11 Worker versions. Releases check version, settings and /health (daily-release.mjs:112-116); no workflow reads /status (workers/daily-playset/src/index.js:43). /status misses content defects: an English/Spanish twin pair reached the founder's inbox (studio/notes/2026-10-05-playset-language-siblings.md:3), fixed by #402.

  3. The daily email's only opt-out link needs a sign-in (email.js:48,102-103; plan.js:27-28); no List-Unsubscribe header (send.js:13-14). Complaints could throttle the root sender carrying sign-in links ([[2026-09-14-scribble-works-email-sending-domains|sending-domain rules]] :23, :26). Noted 09-15, 09-29; never queued.

  4. State: guide broadcasts dry-run (run 37313349858 log); lifecycle sends (welcome too) parked (ROADMAP.md:68); text messages parked (:109), schema email-only (0006_plans_and_deliveries.sql:42).

Proposed queue.md changes

Columns: product (charter :48), engineering (:50). "…" = abbreviated.

@@ -40,0 +41,2 @@
+6. R39
+7. R40
@@ -73 +75 @@
-R28. … Founder-authorize read-only prepare-daily check = doc §5.
+R28. … §5 DONE 2026-10-04 (escalations.md:506).
@@ -87,0 +90,4 @@
+## 2026-10-06 review (reviews/2026-10-06-lifecycle-email-sms.md)
+R39. [engineering, S] Moved from :280-281: 100/day cap alert in `report:email`; reason-only log of sign-in/invite sends (functions/api/auth/request.js:132, invite.js:39).
+R40. [engineering, S] Moved from :338: news.-only sender guard (guides-broadcast.mjs:138), GUIDES.md:398-399, ARCHITECTURE.md rail, workers/daily-playset/README.md:15 date.
+R41. [engineering, M, plan-first GH issue] Daily email: one-click List-Unsubscribe (send.js:13) to a signed pause link. Before #224 (paid plans).
@@ -280,2 +285,0 @@
-- [engineering, S, NEW 2026-09-15] Wire …
-  - [engineering] RESCOPED 2026-09-29: …
@@ -338 +341,0 @@
-- [engineering, S, NEW 2026-09-29] guides-broadcast.mjs: …

Decisions needed

  1. Watch delivery outcomes? Authorize a daily GitHub check of /status counts, failing on any failed or unresolved delivery, with a status-only token (today's can also send, index.js:4,58). Lean: yes. Bear: one more production credential in GitHub; the founder's inbox caught 10-05's defect.
  2. Cited, not re-asked: escalations.md:465 (opt-in, postal address), :466 (Resend plan), :467 (_dmarc still p=none).